Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 시간표 프레임 삭제 관련 에러 수정 #708

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix: 시간표 프레임 삭제 관련 에러 수정 #708

merged 3 commits into from
Jul 19, 2024

Conversation

seongjae6751
Copy link
Contributor

@seongjae6751 seongjae6751 commented Jul 17, 2024 •
edited
Loading

🔥 연관 이슈

🚀 작업 내용

  1. isMain인 프레임을 삭제하면 isMain이 아닌 것 중에 가장 먼저 생성된 것이 isMain이 되도록 jpa의 힘을 빌려 로직을 짰었으나.. jpql로 바꾸게 되면서 생긴 에러 입니다. jpql은 limit을 지원하지 않아서 limit을 지원하는 jpa로 메서드를 다시 변경했습니다.(first)

💬 리뷰 중점사항

@seongjae6751 seongjae6751 added the Team User 유저 팀에서 작업할 이슈입니다 label Jul 17, 2024
@seongjae6751 seongjae6751 self-assigned this Jul 17, 2024
@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Jul 17, 2024
@seongjae6751 seongjae6751 requested review from duehee, daheeParkk and kwoo28 and removed request for duehee July 17, 2024 13:57
@seongjae6751 seongjae6751 changed the title fix: 원래 로직대로 원상 복구 fix: 시간표 프레임 삭제 관련 에러 수정 Jul 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Unit Test Results

  29 files    29 suites   2m 34s ⏱️
241 tests 240 ✔️ 1 💤 0 ❌
242 runs  241 ✔️ 1 💤 0 ❌

Results for commit 2f28409.

♻️ This comment has been updated with latest results.

kwoo28
kwoo28 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@kwoo28 kwoo28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 쿼리문은 여러개 반환할수 있는 경우가 있다는걸 놓쳤었네요.. 수고많으셨습니다!

dradnats1012
dradnats1012 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@dradnats1012 dradnats1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한줄로 되니까 깔끔하네요 👍

@seongjae6751 seongjae6751 merged commit 9115238 into develop Jul 19, 2024
3 checks passed
@seongjae6751 seongjae6751 deleted the fix/705-delete--frame-multiple-results-error branch July 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dradnats1012 dradnats1012 dradnats1012 approved these changes

@kwoo28 kwoo28 kwoo28 approved these changes

@duehee duehee Awaiting requested review from duehee

@daheeParkk daheeParkk Awaiting requested review from daheeParkk

Assignees

@seongjae6751 seongjae6751

Labels
Team User 유저 팀에서 작업할 이슈입니다 버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

시간표 프레임 삭제 API에서 여러 결과 반환 오류 발생
3 participants
@seongjae6751 @dradnats1012 @kwoo28