Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imageUrls가 null인 경우 빈 리스트로 초기화한다. #726

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

20HyeonsuLee
Copy link
Contributor

🔥 연관 이슈

🚀 작업 내용

  1. imageUrls가 null일 경우 nullPointer가 발생하는 이슈를 해결하기 위해 null인 경우 빈 배열로 초기화 해줬습니다.

💬 리뷰 중점사항

@20HyeonsuLee 20HyeonsuLee added 기능 새로운 기능을 개발합니다. Team Business 비즈니스 팀에서 작업할 이슈입니다 labels Jul 23, 2024
@20HyeonsuLee 20HyeonsuLee self-assigned this Jul 23, 2024
@github-actions github-actions bot added the 리팩터링 리팩터링을 위한 이슈입니다 label Jul 23, 2024
@20HyeonsuLee 20HyeonsuLee requested review from YunYongWoon and BaeJinho4028 and removed request for dradnats1012 July 23, 2024 08:23
) {
this.rating = rating;
this.content = content;
this.imageUrls = imageUrls != null ? imageUrls : new ArrayList<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

하.. 코틀린하다 오니까 여기에 null이 들어올 수 있는 상황 자체가 말이안된다... 열받네 자바

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하... ㅠ

Copy link

github-actions bot commented Jul 23, 2024

Unit Test Results

  29 files    29 suites   2m 37s ⏱️
245 tests 244 ✔️ 1 💤 0
246 runs  245 ✔️ 1 💤 0

Results for commit 778bbab.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dradnats1012 dradnats1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어용 👍

@20HyeonsuLee 20HyeonsuLee merged commit fcd0935 into develop Jul 23, 2024
4 checks passed
@20HyeonsuLee 20HyeonsuLee deleted the refactor/725-review-images-null-validation branch July 23, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Business 비즈니스 팀에서 작업할 이슈입니다 기능 새로운 기능을 개발합니다. 리팩터링 리팩터링을 위한 이슈입니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imageUrls null 검사 추가
3 participants