Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: imageUrls가 null인 경우 빈 리스트로 초기화한다. #726

Merged
merged 2 commits into from
Jul 23, 2024
Merged

feat: imageUrls가 null인 경우 빈 리스트로 초기화한다. #726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d835694
feat: imageUrls가 nul인 경우 빈 배열로 초기
Jul 23, 2024
778bbab
feat: JsonProperty스테이크케이스로 변
Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/main/java/in/koreatech/koin/domain/shop/dto/CreateReviewRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

import static io.swagger.v3.oas.annotations.media.Schema.RequiredMode.REQUIRED;

import java.util.ArrayList;
import java.util.List;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.databind.annotation.JsonNaming;

Expand Down Expand Up @@ -37,4 +40,16 @@ public record CreateReviewRequest(
@Schema(example = "[\"치킨\", \"피자\"]", description = "메뉴 이름", requiredMode = REQUIRED)
List<String> menuNames
) {
@JsonCreator
public CreateReviewRequest(
@JsonProperty("rating") @NotNull @Min(1) @Max(5) Integer rating,
@JsonProperty("content") @NotBlank String content,
@JsonProperty("imageUrls") List<String> imageUrls,
@JsonProperty("menuNames") List<String> menuNames
) {
this.rating = rating;
this.content = content;
this.imageUrls = imageUrls != null ? imageUrls : new ArrayList<>();
this.menuNames = menuNames;
}
}
15 changes: 15 additions & 0 deletions src/main/java/in/koreatech/koin/domain/shop/dto/ModifyReviewRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

import static io.swagger.v3.oas.annotations.media.Schema.RequiredMode.REQUIRED;

import java.util.ArrayList;
import java.util.List;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.databind.annotation.JsonNaming;

Expand Down Expand Up @@ -37,4 +40,16 @@ public record ModifyReviewRequest(
@Schema(example = "[\"치킨\", \"피자\"]", description = "메뉴 이름", requiredMode = REQUIRED)
List<String> menuNames
) {
@JsonCreator
public ModifyReviewRequest(
@JsonProperty("rating") @NotNull @Min(1) @Max(5) Integer rating,
@JsonProperty("content") @NotBlank String content,
@JsonProperty("imageUrls") List<String> imageUrls,
@JsonProperty("menuNames") List<String> menuNames
) {
this.rating = rating;
this.content = content;
this.imageUrls = imageUrls != null ? imageUrls : new ArrayList<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

하.. 코틀린하다 오니까 여기에 null이 들어올 수 있는 상황 자체가 말이안된다... 열받네 자바

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하... ㅠ

this.menuNames = menuNames;
}
}
Loading