fix : 시간표 프레임 삭제 동시성 #731
Merged
fix : 시간표 프레임 삭제 동시성 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duehee
approved these changes
Jul 26, 2024
| @@ -18,6 +18,11 @@ public interface TimetableFrameRepositoryV2 extends Repository<TimetableFrame, I | |||
|
|
|||
| Optional<TimetableFrame> findById(Integer id); | |||
|
|
|||
| @Lock(LockModeType.PESSIMISTIC_WRITE) | |||
| @Query("SELECT t FROM TimetableFrame t WHERE t.id = :id") | |||
| Optional<TimetableFrame> findByIdWithLock(@Param("id") Integer id); | |||
There was a problem hiding this comment.
A
findById 자체에 Lock을 거는 것을 생각했는데, 메소드를 따로 분리하셨네요!👍
There was a problem hiding this comment.
findById는 delete뿐 아니라 여러 트랜잭션에서 사용되는거라 필요한 상황에서만 쓸 수 있게 분리시켰습니다ㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
findFirstByUserIdAndSemesterIdAndIsMainFalseOrderByCreatedAtAsc()메서드에 베타락을 걸어도 여전히 위와같은 2개의 트랜잭션이 동시에 접근되는 상황에서 여전히 동시성 에러가 발생되고 있습니다. 이유는 사진과 같이 findById는 여전히 해당 레코드를 공유하여 접근하기 때문에 충돌이 발생합니다.
그래서 findById메서드 또한 베타락을 걸어서 다른 트랜잭션에서 findById 사용할때 해당 레코드에 동시에 접근하는 것을 막게 수정했습니다.
💬 리뷰 중점사항