feat: 혜택 카테고리, 상점 조회 API 작성 #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 11, 2024 16:52
20HyeonsuLee
requested review from
Choi-JJunho,
Backend-Changyeon and
BaeJinho4028
BaeJinho4028
approved these changes
Sep 15, 2024
src/main/java/in/koreatech/koin/domain/benefit/dto/BenefitCategoryResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/benefit/dto/BenefitCategoryResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/benefit/controller/BenefitApi.java
Outdated
Show resolved
Hide resolved
added 4 commits
September 16, 2024 13:20
… feature/880-get-benefit-category
dradnats1012
approved these changes
Sep 18, 2024
|
|
||
| private final ShopBenefitService shopBenefitService; | ||
|
|
||
| @GetMapping("/benefit/categories") |
There was a problem hiding this comment.
/benefit 공통이라 뺴도 될것 같아요
| public record BenefitCategoryResponse( | ||
| @Schema(description = "혜택 카테고리 리스트", requiredMode = NOT_REQUIRED) | ||
| List<InnerBenefitResponse> benefits | ||
|
|
added 4 commits
September 18, 2024 19:40
… feature/880-get-benefit-category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
이번 PR머지시키고 상점 조회에서 query dsl활용해서 성능 최적화 한번 시도해보려고 합니다.