refactor: 많이 조회하는 키워드 테이블 제약 조건 추가 #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongjae6751
requested review from
songsunkook,
ImTotem,
dradnats1012 and
Choon0414
songsunkook
approved these changes
Sep 19, 2024
| import lombok.Builder; | ||
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @Getter | ||
| @Entity | ||
| @Table(name = "article_search_keyword_ip_map", indexes = { | ||
| @Index(name = "idx_ip_address", columnList = "ipAddress") | ||
| @Index(name = "idx_ip_address", columnList = "ipAddress")}, uniqueConstraints = { | ||
| @UniqueConstraint(name = "ux_keyword_ip", columnNames = {"keyword_id", "ipAddress"}) |
There was a problem hiding this comment.
C
유니크를 걸어둬도 유니크 필드가 중복되면 결국 에러가 발생하는 것 아닌가요? 유니크만 걸어둬도 괜찮나요?
There was a problem hiding this comment.
동시성 제어 어노테이션으로 나중에 어플리케이션 단에서 막을 것입니다!
duehee
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
원래 동시성 제어 어노테이션이랑 같이 처리 할 생각이였는데 생각보다 동시성 제어 작업이 길어진 점과.. 따로 올리는 것이 낫겠다는 생각이 들어서 급히 올립니다.