feat: 어드민 혜택 상점 및 자동완성 검색기능 추가 #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaeJinho4028
requested review from
Choi-JJunho,
Backend-Changyeon,
dradnats1012 and
20HyeonsuLee
20HyeonsuLee
requested changes
Sep 21, 2024
src/main/java/in/koreatech/koin/admin/benefit/repository/AdminBenefitCategoryMapRepository.java
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/benefit/model/BenefitCategory.java
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/dto/AdminCreateBenefitShopsResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/dto/AdminBenefitShopsResponse.java
Outdated
Show resolved
Hide resolved
20HyeonsuLee
approved these changes
Sep 22, 2024
Choi-JJunho
approved these changes
Sep 23, 2024
| String offImageUrl | ||
| ) { | ||
|
|
||
| public static InnerBenefitResponse from(BenefitCategory benefitCategory) { |
There was a problem hiding this comment.
C
외부에서 InnerBenefitResponse 를 만들어서 사용할 일이 있나요?
없다면 접근제어자를 private으로 설정하는건 어떨까요?
There was a problem hiding this comment.
잊고있었네요. 좋은 지적 감사합니다! 아래도 동일하게 수정하겠습니다!
| String name | ||
| ) { | ||
|
|
||
| public static InnerShopResponse from(Shop shop) { |
There was a problem hiding this comment.
C
외부에서 InnerBenefitResponse 를 만들어서 사용할 일이 있나요?
없다면 접근제어자를 private으로 설정하는건 어떨까요?
ditto
|
|
||
| void deleteById(Integer id); | ||
|
|
||
| int count();; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
Normal 버전에 on/off image_url이 없어서 추가하였고, json 필드를 snake_case로 통일했습니다.