feat: 로그인 여부 확인 API #913
Merged
feat: 로그인 여부 확인 API #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaeJinho4028
approved these changes
Sep 23, 2024
| @Operation(summary = "로그인 여부 확인") | ||
| @SecurityRequirement(name = "Jwt Authentication") | ||
| @GetMapping("/user/check/login") | ||
| ResponseEntity<Void> checklogin( |
There was a problem hiding this comment.
밑에보니 checkLogin인데 통일하는 것이 좋을것 같습니다.
|
|
||
| public record UserAccessTokenRequest( | ||
| @Schema(description = "access_token", example = "eyJ0eXAiOiJKV1QiLCJhbGcIUzUxMic9.eyJpZCI6NTM5NhwIjoxkzI3MTA5ODE5fQ.rLEYGQfKI5_24ZlwLVwlgwnriqySPKwXNOeTRrbmxoCtlOzCVvM8FFcO9BA2vkqsmhf-w", requiredMode = REQUIRED) | ||
| @NotNull(message = "access_token을 입력해주세요.") |
There was a problem hiding this comment.
@NotBlank 를 안쓰신 이유가 궁금합니다!
There was a problem hiding this comment.
그 부분을 깜빡했네요.. 지적 감사합니다ㅣ
There was a problem hiding this comment.
@NotBlank 있으면 @NotNull은 없어도 될 거 같아요
| @@ -171,6 +155,15 @@ public ResponseEntity<Void> findPassword( | |||
| return new ResponseEntity<>(HttpStatusCode.valueOf(201)); | |||
| } | |||
|
|
|||
| @GetMapping("/user/check/login") | |||
| public ResponseEntity<Void> checklogin( | |||
There was a problem hiding this comment.
이곳도 동일하게 checkLogin 으로 바꿔주시면 좋겠습니다!
duehee
approved these changes
Sep 24, 2024
|
|
||
| public record UserAccessTokenRequest( | ||
| @Schema(description = "access_token", example = "eyJ0eXAiOiJKV1QiLCJhbGcIUzUxMic9.eyJpZCI6NTM5NhwIjoxkzI3MTA5ODE5fQ.rLEYGQfKI5_24ZlwLVwlgwnriqySPKwXNOeTRrbmxoCtlOzCVvM8FFcO9BA2vkqsmhf-w", requiredMode = REQUIRED) | ||
| @NotNull(message = "access_token을 입력해주세요.") |
There was a problem hiding this comment.
@NotBlank 있으면 @NotNull은 없어도 될 거 같아요
| @@ -18,24 +20,6 @@ | |||
| import org.springframework.web.bind.annotation.RestController; | |||
| import org.springframework.web.servlet.ModelAndView; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항