Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : TimetableLecture Response 컬럼 추가 / TimetableFrame 생성 시 이름 지정 가능 #922

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat : TimetableLecture Response 컬럼 추가 / TimetableFrame 생성 시 이름 지정 가능 #922

merged 2 commits into from
Sep 25, 2024

Conversation

duehee
Copy link
Contributor

@duehee duehee commented Sep 25, 2024

🔥 연관 이슈

🚀 작업 내용

  1. TimetableLecture Response DTO에 lecture_id를 추가했습니다.
  2. TImetableFrame create시 이름을 지정할 수 있도록 Request DTO에 timetableName을 추가했습니다.
  • NOT_REQUIRED로 설정해서 입력하지 않을 시 전과 같이 "시간표1"로 만들어집니다.
  • timetableFrame 관련하여 DTO 내의 이름도 timetableName으로 통일했습니다.

💬 리뷰 중점사항

커스텀 시간표에서 사용 예정입니다~ 승주님이 수요일까지 해달라셨는데 조금 늦었네요 ㅎ....

@duehee duehee added the Team User 유저 팀에서 작업할 이슈입니다 label Sep 25, 2024
@duehee duehee self-assigned this Sep 25, 2024
@github-actions github-actions bot added the 기능 새로운 기능을 개발합니다. label Sep 25, 2024
@github-actions GitHub Actions
Copy link

Unit Test Results

308 tests   307 ✔️  1m 16s ⏱️
  35 suites      1 💤
  35 files        0 ❌

Results for commit c617366.

kwoo28
kwoo28 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@kwoo28 kwoo28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다!

daheeParkk
daheeParkk approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@daheeParkk daheeParkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@duehee duehee merged commit 36e29c4 into develop Sep 25, 2024
6 checks passed
@duehee duehee deleted the feature/916-add-timetable-lecture-lecture-id branch September 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daheeParkk daheeParkk daheeParkk approved these changes

@kwoo28 kwoo28 kwoo28 approved these changes

@seongjae6751 seongjae6751 Awaiting requested review from seongjae6751

@dradnats1012 dradnats1012 Awaiting requested review from dradnats1012

Assignees

@duehee duehee

Labels
Team User 유저 팀에서 작업할 이슈입니다 기능 새로운 기능을 개발합니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimetableLecture Response lecture_id 추가
3 participants
@duehee @daheeParkk @kwoo28