Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 모든 상점 조회 V2 응답시간 최적화 #931

Merged
merged 12 commits into from
Oct 1, 2024
Merged

refactor: 모든 상점 조회 V2 응답시간 최적화 #931

merged 12 commits into from
Oct 1, 2024

Conversation

20HyeonsuLee
Copy link
Contributor

@20HyeonsuLee 20HyeonsuLee commented Sep 30, 2024 •
edited
Loading

🔥 연관 이슈

🚀 작업 내용

  1. 이제 모든 상점 조회 API에서 상점 오픈시간 대신 is_open필드만 제공하기 때문에 opens를 모두 db에서 긁어올 필요가 없습니다.
    • 약 600의 opens를 가져오는 DB I/O시간을 최적화 하였음.
  2. 정렬의 책임을 DTO에 위임하였음
    • ShopsFilterCriteria, ShopsSortCriteria가 기존에 Entity를 의존했지만 DTO를 의존하도록 변경

💬 리뷰 중점사항

@20HyeonsuLee 20HyeonsuLee self-assigned this Sep 30, 2024
@github-actions github-actions bot added the 리팩터링 리팩터링을 위한 이슈입니다 label Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Unit Test Results

308 tests   307 ✔️  1m 22s ⏱️
  35 suites      1 💤
  35 files        0 ❌

Results for commit 746387f.

♻️ This comment has been updated with latest results.

@20HyeonsuLee 20HyeonsuLee reopened this Sep 30, 2024
BaeJinho4028
BaeJinho4028 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@BaeJinho4028 BaeJinho4028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다. 줄넘김 정도만 체크하고 머지해주세요

src/main/java/in/koreatech/koin/domain/shop/repository/shop/dto/ShopInfoV1.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/domain/shop/repository/shop/dto/ShopInfoV2.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/domain/shop/model/shop/Shop.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/domain/shop/repository/shop/dto/DurationTime.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/domain/shop/dto/shop/ShopsFilterCriteria.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/domain/shop/repository/shop/dto/ShopCustomRepository.java Show resolved Hide resolved
krSeonghyeon
krSeonghyeon approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@krSeonghyeon krSeonghyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

src/main/java/in/koreatech/koin/domain/shop/dto/shop/ShopsResponseV2.java Outdated Show resolved Hide resolved
@20HyeonsuLee 20HyeonsuLee merged commit f4f23c1 into develop Oct 1, 2024
4 checks passed
@20HyeonsuLee 20HyeonsuLee deleted the refactor/919-query-optimize branch October 1, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaeJinho4028 BaeJinho4028 BaeJinho4028 approved these changes

@krSeonghyeon krSeonghyeon krSeonghyeon approved these changes

@Choi-JJunho Choi-JJunho Awaiting requested review from Choi-JJunho

@Backend-Changyeon Backend-Changyeon Awaiting requested review from Backend-Changyeon

@Choon0414 Choon0414 Awaiting requested review from Choon0414

@johnny19991006 johnny19991006 Awaiting requested review from johnny19991006

Assignees

@20HyeonsuLee 20HyeonsuLee

Labels
리팩터링 리팩터링을 위한 이슈입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

모든 상점 조회 API 성능최적화
3 participants
@20HyeonsuLee @BaeJinho4028 @krSeonghyeon