feat: 시간표 조회 API 이수 구분 반환 추가 #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
requested review from
seongjae6751,
daheeParkk,
20HyeonsuLee,
kwoo28 and
duehee
kwoo28
approved these changes
Oct 2, 2024
duehee
approved these changes
Oct 4, 2024
| ); | ||
| } | ||
|
|
||
| public CourseType HRD_필수() { |
There was a problem hiding this comment.
C
HRD 필수인데 MSC 필수로 되어있어요!! 오타? 👀
There was a problem hiding this comment.
실수로 아래를 안 땡겨서 리뷰를.. 아래 save쪽이에요
There was a problem hiding this comment.
LectureFixture에 HRD_개론 이름으로 되어 있고 내용은 컴퓨팅사고이길레 기존거는 냅두고 CourseType를 다음과 같이 작성했습니다..!
duehee
approved these changes
Oct 5, 2024
| CourseType courseType = timetableLectureRequest.courseTypeId() == null ? | ||
| null : courseTypeRepository.getCourseTypeById(timetableLectureRequest.courseTypeId()); | ||
|
|
||
| CourseType courseType = lecture == null ? |
There was a problem hiding this comment.
C
라인 포맷팅 안 되어있나요?? 2줄로 나뉠 로직이 아닌 거 같아서요👀
Comment on lines
136
to
137
| String code = lecture.getCode(); | ||
|
|
…-graduation-credit-calculator
Soundbar91
merged commit fbefe93
into
feature/929-graduation-credit-calculator
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
GET /v2/timetables/lecture의 응답에이수 구분추가POST /v2/timetables/lecture의 요청에서 year, department, code를 이용해서이수 구분 id저장💬 리뷰 중점사항
student 테이블의 year, department와 timetable_lecture의 code를 이용해서 catalog 테이블의 id를 얻습니다.
catalog의 id를 이용해서 course_type_id를 찾아서 timetable_lecture에 저장하도록 작성했습니다.
timetable_lecture의 course_type_id를 이용해서
이수 구분을 응답으로 반환하도록 작성했습니다.첫 PR 리뷰 부탁드립니다..!