feat: 어드민 상점 혜택 카테고리 수정 기능 추가 #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20HyeonsuLee
approved these changes
Oct 4, 2024
src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java
Show resolved
Hide resolved
Comment on lines
+66
to
+68
| BenefitCategory benefitCategory = adminBenefitCategoryRepository.getById(categoryId); | ||
| benefitCategory.update(request.title(), request.detail(), request.onImageUrl(), request.offImageUrl()); | ||
| return AdminModifyBenefitCategoryResponse.from(benefitCategory); |
There was a problem hiding this comment.
C
수정할때도 동일한 이름의 카테고리가 있는지 검증해줄 필요가 있어보여요
There was a problem hiding this comment.
맞네요. 좋은 피드백 감사합니다. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
명세서대로 어드민 상점 혜택 카테고리 수정 기능 추가 및 테스트 간단하게 작성하였습니다.