Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: article 로직 수정 #946

Merged
merged 2 commits into from
Oct 5, 2024
Merged

fix: article 로직 수정 #946

merged 2 commits into from
Oct 5, 2024

Conversation

DHkimgit
Copy link
Contributor

@DHkimgit DHkimgit commented Oct 5, 2024

🔥 연관 이슈

🚀 작업 내용

  1. registered_at이 null값을 반환하지 않도록 수정

💬 리뷰 중점사항

@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Oct 5, 2024
Copy link
Collaborator

@songsunkook songsunkook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 대응 감사합니다 👍

Comment on lines 125 to 126
} else
return null;
return this.getCreatedAt().toLocalDate();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C

else는 없어도 될 것 같아요

Copy link

github-actions bot commented Oct 5, 2024

Unit Test Results

318 tests   317 ✔️  1m 12s ⏱️
  36 suites      1 💤
  36 files        0

Results for commit b7c9496.

♻️ This comment has been updated with latest results.

@DHkimgit DHkimgit merged commit e0819a1 into develop Oct 5, 2024
4 checks passed
@DHkimgit DHkimgit deleted the fix/article-registered-at branch October 5, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants