feat: 영양사님 엑셀 다운로드 기능 구현 #947
Merged
+198
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songsunkook
approved these changes
Oct 6, 2024
|
|
||
| @ApiResponses( | ||
| value = { | ||
| @ApiResponse(responseCode = "201"), |
There was a problem hiding this comment.
A
실제로는 200이 반환되고 있는 것 아닌가요??
| @@ -90,4 +111,103 @@ public CoopLoginResponse coopLogin(CoopLoginRequest request) { | |||
|
|
|||
| return CoopLoginResponse.of(accessToken, savedToken.getRefreshToken()); | |||
| } | |||
|
|
|||
| public ByteArrayInputStream generateCoopExcel(LocalDate startDate, LocalDate endDate, Boolean isCafeteria) { | |||
There was a problem hiding this comment.
A
coopExcel 말고 diningExcel은 어떻게 생각하세요??
There was a problem hiding this comment.
A
저도 diningExcel 좋은 것 같습니다
There was a problem hiding this comment.
음 영양사님이 쓰시는거라서 coop으로 했는데 반환되는건 결국 식단이니까 dining 가 좋을것 같네요
| @@ -44,6 +62,8 @@ public class CoopService { | |||
| private final PasswordEncoder passwordEncoder; | |||
| private final JwtProvider jwtProvider; | |||
|
|
|||
| private final int CELL_NUM = 8; | |||
There was a problem hiding this comment.
A
이건 어디서 사용하는 상수인가요?? 용도를 파악하기 힘든 것 같아요
There was a problem hiding this comment.
cell 만들때 for문에 상수 들어가 있는게 보기 안좋아서 따로 뺐습니다!
kih1015
approved these changes
Oct 6, 2024
Comment on lines
71
to
73
| return ExcelResponseBuilder.buildExcelResponse(excelFile, startDate, endDate); | ||
|
|
||
| } |
Comment on lines
123
to
126
| } | ||
|
|
||
|
|
||
| try (Workbook workbook = new XSSFWorkbook()) { |
Choon0414
approved these changes
Oct 6, 2024
| @@ -90,4 +111,103 @@ public CoopLoginResponse coopLogin(CoopLoginRequest request) { | |||
|
|
|||
| return CoopLoginResponse.of(accessToken, savedToken.getRefreshToken()); | |||
| } | |||
|
|
|||
| public ByteArrayInputStream generateCoopExcel(LocalDate startDate, LocalDate endDate, Boolean isCafeteria) { | |||
There was a problem hiding this comment.
A
저도 diningExcel 좋은 것 같습니다
| dinings.forEach(dining -> { | ||
| Row row = sheet.createRow(rowIdx.getAndIncrement()); | ||
| row.createCell(0).setCellValue(dining.getDate().toString()); | ||
| row.createCell(1).setCellValue(dining.getType().toString()); |
There was a problem hiding this comment.
A
type을 enum으로 반환하기보다 이름(diningName)로 반환하는건 어떠신가요?
dining.getType() → "BREAKFAST"
dining.getType().getDiningName() → "아침"
There was a problem hiding this comment.
오 좋아요
이건 생각 못했네용 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항