Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 어드민 공지 조회 API 버그 수정 #949

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

songsunkook
Copy link
Collaborator

🚀 작업 내용

  1. 어드민 페이지에서 코인 공지 (단건, 리스트) 조회 시 소프트딜리트된 대상이 검색 대상에 포함되면 NPE가 발생하는 문제를 해결했습니다.

💬 리뷰 중점사항

@songsunkook songsunkook self-assigned this Oct 6, 2024
@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Oct 6, 2024
@github-actions github-actions bot requested a review from kwoo28 October 6, 2024 12:09
Copy link

github-actions bot commented Oct 6, 2024

Unit Test Results

319 tests   318 ✔️  1m 24s ⏱️
  36 suites      1 💤
  36 files        0

Results for commit d13a975.

Copy link
Contributor

@DHkimgit DHkimgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 제가 테스트 코드 작성할 때 케이스 세분화해서 확인했어야 하는 부분인데 죄송합니다 ...

Copy link
Contributor

@Choon0414 Choon0414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@songsunkook songsunkook merged commit 8250ab1 into develop Oct 6, 2024
6 checks passed
@songsunkook songsunkook deleted the fix/admin-notice-api-soft-delete branch October 6, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants