fix: 상점 카테고리 아이디가 사라지는 에러 수정 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoooooony
reviewed
Mar 7, 2024
|
@hoooooony 2개 이상인 경우 고려해야 하네요 전체 카테고리를 가져오도록 수정했습니다. 4b555c6 |
hoooooony
approved these changes
Mar 7, 2024
ChoiWonBeen
reviewed
Mar 7, 2024
Comment on lines
+136
to
+140
| if (shopInfo.shop_categories.length === 1) { | ||
| setValue('category_ids', [shopInfo.shop_categories[0].id]); | ||
| } else { | ||
| setValue('category_ids', [1, categoryId]); | ||
| const categoryIds = shopInfo.shop_categories.map((category) => category.id); | ||
| setValue('category_ids', categoryIds); |
There was a problem hiding this comment.
앗 그렇네요... 전체보기 카테고리를 반드시 나눠야한다고 접근해서 그런 것 같네요
리펙토링할 때 참고하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#169]request
Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?Screenshot
가게 수정 시 카테고리 아이디가 지워지지 않도록 변경하였습니다.
2024-03-07.1.33.57.mov
Precautions (main files for this PR ...)
Close #169