[공통] 헤더, 사이드 패널 컴포넌트화 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dooohun
approved these changes
Apr 15, 2024
Comment on lines
+12
to
+13
| LABEL1: 'mega-menu-label-1', | ||
| LABEL2: 'mega-menu-label-2', |
There was a problem hiding this comment.
변수명을 좀 더 구체적으로 표현하는게 좋을 거 같아요!
There was a problem hiding this comment.
아 사용하지 않는 변수군요? 그렇다면 지워도 될 것 같아요!
There was a problem hiding this comment.
제 추측입니다만 추후 확장을 고려해서 예시 라벨을 넣어놓은 것 같습니다.
| @@ -0,0 +1,264 @@ | |||
| .mobileheader { | |||
There was a problem hiding this comment.
Suggested change
| .mobileheader { | |
| .mobile-header { |
mobile-header 아닌가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?