[공통] 데이터가 stale일때 refetch 되도록 수정 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
기존 queryClient 설정을 보면 refetchOnMount가 false로 지정되어 있어 쿼리 무효화를 시켜서 데이터가 stale상태가 되어도 refect가 안되는 경우가 있었습니다. 이 값을 true로 바꿔서 invalidationQueries가 원하는대로 동작하도록 수정했습니다.
또한 추가로 refetchOnWindowFocus, refetchOnReconnect도 false인 점이 불필요하다고 판단되어 true로 수정했습니다.
기존에 invalidation이 동작하지 않아서 refetchQueries 또는 useQuery의 refetch를 사용하신 부분이 많이 있을 겁니다.
자신이 수정했던 부분을 기억하셔서 불필요한 refetch가 이루어지지 않는지 다들 한번씩 확인 부탁드리겠습니다
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?