[공통] 비즈니스팀 2차 QA 이슈 해결 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiWonBeen
reviewed
Apr 22, 2024
Comment on lines
102
to
105
| if (isKoinError(e)) { | ||
| showToast('error', e.message); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Suggested change
| if (isKoinError(e)) { | |
| showToast('error', e.message); | |
| } | |
| }, | |
| if (isKoinError(e)) { | |
| showToast('error', e.message); | |
| return; | |
| } | |
| sendClientError(e); | |
| }, |
실패시 처리 확인할 수 있게 올려주세요~~
There was a problem hiding this comment.
a6d9678
굿~ 적용했습니다
ChoiWonBeen
approved these changes
Apr 22, 2024
hoooooony
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
아마 이번에 문자 인증을 도입하고 리펙토링하면 회원가입, 비밀번호 찾기쪽의 로직이 많이 변경되겠지만...
주말동안 시간이 있어서 안되던 동작들을 수정해봤습니다
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?