[리팩토링] 메뉴 추가 페이지 컴포넌트 분할 및 에러 분기 추가 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haejinyun
reviewed
Jun 11, 2024
src/page/AddMenu/index.tsx
Outdated
Comment on lines
63
to
68
| if (addMenuError) { | ||
| showToast('error', '메뉴 추가에 실패했습니다.'); | ||
| } else { | ||
| navigate('/owner'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
위 부분에서 궁금한 점이 있습니다!
addMenuMutation 안에서 onSuccess와 함께
onError: () => { },
이런 방향으로 처리하는 방식은 어떤가요? mutationFn의 성공, 실패에 따른 처리가 한 곳에 있는 것이 좋지 않을까?라는 생각이 들어 남겨봅니다!
There was a problem hiding this comment.
Mutation에 onError 로 처리했습니다. 0a988a1
hoooooony
approved these changes
Jun 12, 2024
hoooooony
reviewed
Jun 12, 2024
src/page/AddMenu/index.tsx
Outdated
| goMyShop(); | ||
|
|
||
| const onClickMenuAddConfirmHandler = (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
mouse이벤트에 막아줘야할 기본적인 동작이 있나요?
There was a problem hiding this comment.
막아줘야할 부분이 딱히 없는 것으로 확인되어서 다시 제거하였습니다. 0a988a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint