Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[비즈니스] 계좌번호 등록 기능 추가 #370

Merged
merged 10 commits into from
Jul 4, 2024

Conversation

chaeseungyun
Copy link
Contributor

@chaeseungyun chaeseungyun commented Jul 2, 2024

What is this PR? 🔍

  • 기능 : 계좌번호 등록 기능 추가
  • issue : #

Changes 📝

가게 관리하기 탭에서 사장님이 원한다면 계좌번호를 추가할 수 있습니다.
은행명만 입력하거나 계좌번호만 입력한 경우 에러처리를 했습니다.
사용자는 -가 포함된 계좌번호를 입력해야 합니다

또한 가게 이미지가 한 번에 최대 3개가 보여지도록 수정했습니다

ScreenShot 📷

image
image
image
image

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@chaeseungyun chaeseungyun self-assigned this Jul 2, 2024
@chaeseungyun chaeseungyun added the ✨ Feature 기능 개발 label Jul 3, 2024
Copy link
Contributor

@daepan daepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
전역상태, Watch 사용해서 코드에 변경 보다는 추가가 많아 크게 리뷰할게 없군요!
몇가지 질문 남겨놨습니다. 읽어보시고 답변 남겨주세요

Copy link
Contributor

@daepan daepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@chaeseungyun chaeseungyun merged commit 46268d3 into develop Jul 4, 2024
1 check passed
@chaeseungyun chaeseungyun deleted the feat/add_modify_shop_account_input branch July 4, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

계좌번호 등록 기능 추가
2 participants