Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[비즈니스] 회원가입 인증번호 확인 버튼, 토스트 추가 #373

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

hoooooony
Copy link
Contributor

  • Close #ISSUE_NUMBER

What is this PR? 🔍

  • 기능 : 회원가입 인증번호 확인 버튼, 토스트 추가
  • issue : #

Changes 📝

인증번호 확인을 기존에는 6자리가 되면 자동으로 확인하였지만 확인 버튼으로 확인 할 수 있도록 변경
인증번호 전송, 확인 토스트 추가

ScreenShot 📷

image image

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@hoooooony hoooooony added the ❗QA issue QA 이슈 label Jul 12, 2024
@hoooooony hoooooony self-assigned this Jul 12, 2024
Copy link
Contributor

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@@ -180,15 +188,26 @@ export default function PhoneStep({ setIsStepComplete }: PhoneStepProps) {
message: '인증번호를 입력해주세요',
},
pattern: {
value: /^[0-9]+$/,
message: '인증번호가 일치하지 않습니다.',
value: /^[0-9]{6}$/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 정규식들은 따로 상수로 빼도 될것 같아요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋네요 😁

@hoooooony hoooooony merged commit 7b1bd60 into develop Jul 13, 2024
2 checks passed
@github-actions github-actions bot deleted the feat/sms_confirm_button_registration branch July 13, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗QA issue QA 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants