Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[비즈니스] 사이즈 추가 로직, css 에러수정 #375

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

hoooooony
Copy link
Contributor

  • Close #ISSUE_NUMBER

What is this PR? 🔍

  • 기능 : 사이즈 추가 로직, css 에러수정
  • issue : #

Changes 📝

사이즈 추가 버튼 무반응 에러수정
삭제 아이콘 css 수정

ScreenShot 📷

2024-07-13.5.17.08.mov

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@hoooooony hoooooony added the 🐞 BugFix 버그 해결 label Jul 13, 2024
@hoooooony hoooooony self-assigned this Jul 13, 2024
@github-actions github-actions bot requested review from daepan and dooohun July 13, 2024 08:19
Copy link
Contributor

@dooohun dooohun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!!

@@ -46,7 +49,7 @@ export default function MenuPrice({ isComplete }:MenuPriceProps) {

if (updatedOptionPrices.length === 0) {
setIsSingle(true);
setOptionPrices([]);
setOptionPrices([{ id: 0, option: '', price: 0 }]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위 코드랑 초기화 하는 로직이 똑같은데 따로 변수를 만들거나 초기화하는 함수를 따로 만드는 것도 괜찮을 거 같아요!

@chaeseungyun chaeseungyun merged commit de33817 into develop Jul 13, 2024
1 check passed
@github-actions github-actions bot deleted the fix/size_input_add_error branch July 13, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 BugFix 버그 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants