Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[비즈니스] 비밀번호 자동완성 막기 #377

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

chaeseungyun
Copy link
Contributor

  • Close #ISSUE_NUMBER

What is this PR? 🔍

  • 기능 :
  • issue : #

Changes 📝

아이폰 사용자의 경우 비밀번호 인풋에 비밀번호가 자동 추천되는데, 길이가 18자를 넘어서 사용할 수 없는 불편함이 있습니다.
또한 계좌번호 바텀시트 마운트 시 포커스가 바뀌지 않아 크롬 브라우저에서 보기 불편했던 현상을 수정했습니다

ScreenShot 📷

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@chaeseungyun chaeseungyun self-assigned this Jul 15, 2024
Copy link
Contributor

@daepan daepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 문득 든 생각이지만 저희 인증번호 모바일로 요청하면 메시지로 온거 자동 추적하나요?
(진짜 모름) 바로 해보고 안되면 처리해봐야겠군요 요즘 이거 없으면 짜증나는 시대가 와버린..

src/page/Auth/Login/index.tsx Show resolved Hide resolved
Copy link
Contributor

@junghaesung79 junghaesung79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

src/page/Auth/Login/index.tsx Show resolved Hide resolved
@chaeseungyun chaeseungyun merged commit 06fe848 into main Jul 15, 2024
2 checks passed
@github-actions github-actions bot deleted the fix/disable-auto-complete branch July 15, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants