[소그룹스터디] routes를 static으로 관리 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiWonBeen
reviewed
Sep 17, 2024
src/static/routes.ts
Outdated
Comment on lines
20
to
25
| OwnerOrderManagement: () => '/owner/order-management', | ||
| OwnerSalesmanagement: () => '/owner/sales-management', | ||
| OwnerEvent: ({ id, isLink }: ROUTESParams<'id'>) => (isLink ? `/owner/event-add/${id}` : '/owner/event-add/:id'), | ||
| OwnerEventModify: ({ id, isLink }: ROUTESParams<'id'>) => (isLink ? `/owner/event-modify/${id}` : '/owner/event-modify/:id'), | ||
| Login: () => '/login', | ||
| Signup: () => '/signup', |
There was a problem hiding this comment.
소소하지만 / 구분과 - 구분이 전부 대문자로 통일되어서 헷갈리기 쉽겠다 싶은데,
/ 구분을 객체로 넣어서 담는건 어떨까요?? 실제로 /는 레포지토리 뎁스를 의미하니, 코드를 사용할때도 같은 느낌으로 사용할 수 있을 것 같아욥
소소하게 salesManagement만 중간에 대문자가 빠지기도 했구요!
Owner: {
OrderManagement: () => `/owner/order-management`,
SalesManagement: () => `/owner/sales-management`,
}There was a problem hiding this comment.
좋은 방법인 것 같아요! 반영했습니다. 54691a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
static폴더 내의routes.ts에서 모든 경로를 관리하는 것으로 변경하였습니다.ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint