refactor: staleTime제거 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghaesung79
approved these changes
Sep 1, 2024
D0Dam
reviewed
Sep 1, 2024
There was a problem hiding this comment.
BCSDLab/KOIN_WEB_RECODE#469 (review)
초기에 staleTime 왜 줬었죠? retry: false 도 주었던 이유를 모르겠네요..
이번 블로그와 함께 한번 default option이랑 staleTime을 정리한듯 하군요. 항상 고생이 많으십니다 (꾸벅)
D0Dam
approved these changes
Sep 1, 2024
haejinyun
approved these changes
Sep 2, 2024
Gwak-Seungju
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
queryClient에 초기값으로 지정한 staleTime을 제거합니다. 다른 초기값과 동일한 옵션들도 제거합니다.
Changes 📝
BCSDLab/KOIN_WEB_RECODE#469 PR과 동일합니다
Precaution
사이드이펙이 있을 수 있습니다. 기능을 한번씩은 수행해보며 경험을 체크하는게 좋아보입니다
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint