-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aiyatsbus plugin support #987
Comments
I am sadly not gonna add support to this plugin as it is not that big (it's not even on Spigot). |
After my tests, RoseStacker doesn't have this problem. I want to know exactly what the difference is that causes it. |
I think the item duplication problem is caused by the repeated calculation of BlockDropItemEvent in WildStacker and blockbreakEvent in the enchantment plugin. I checked the code of RoseStacker and it doesn't involve the part of BlockDropItemEvent, so this problem doesn't occur. I know you're a master in writing plugins. I have no idea how to solve this problem. As for the size of the enchantment plugin, I think whether a plugin can be noticed shouldn't depend on its popularity, but on its future full of possibilities. |
Ask the developers of that plugin to fix it on their side. |
Blast_mining can only destroy 12 blocks per tick, while level one blast_mining can destroy 18 blocks and it requires 2 ticks. Since wildstacker judges BlockDropEvent which comes after BlockBreakEvent, and the stacking is asynchronous with a delay, it conflicts when blast_mining destroys blocks in the second tick. Plus, there's a 1-tick delay in collecting items with telekinesis. I tried and found that setting the delay of telekinesis to 2 ticks would result in fewer duplications. There should be no such issue after 4 ticks. Because RoseStacker uses BlockBreakEvent and doesn't have much asynchronous code, there are no problems caused by delays. |
I'll look into it. |
OK, I'll try to replicate its key code. If you can make do with using the plugin itself as a second choice, I can also send it to you. |
Minecraft's Version
leaf 1.21.1
Plugin's Version
2024.4
Describe the bug
https://github.com/MCStarrySky/Aiyatsbus
This is a More Enchantments plugin. When I enchant both telekinesis and blast_mining at the same time, if I mine any block pile that is 3*3 at the bottom and 2 at the height, it will cause the dropped items to duplicate. I tried RoseStacker and there was no such problem. I've been trying for a whole night and don't know where to start to solve it. Your plugin is very important to me. Hope you can take a look and help.
To Reproduce
Enchant a pickaxe with both telekinesis and blast_mining at the same time. Place blocks with a base of 3*3 and a height of 2. Dig them from top to bottom, and it will cause the dropped items to double.
Additional Information
No response
The text was updated successfully, but these errors were encountered: