BHoM_Engine: refactor to follow BHoM_Adapter refactoring Level1 #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M_Adapter-refactoring-Level1
alelom
changed the title
|
Looks good to me |
al-fisher
added
the
status:WIP
alelom
removed
the
status:WIP
IsakNaslundBh
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Tested together with BHoM/BHoM_Adapter#120
Whilst on that branch with the of the adapter these changes work. Makes the whole method a whole lot simpler.
Important: Needs to NOT be merged before the adapter
That is now merged -- I would like to push this through so I can get started with the second level refactoring that has been postponed for too long now. |
|
Merged per request from @alelom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
BHoM/BHoM_Adapter#120
Issues addressed by this PR
Fixes: #1093
Having modified the Push to do deepClone, then the Engine method
DistinctPropertiescan be simplified.Additional notes
See BHoM/BHoM_Adapter#84 for description of all refactoring issues for the BHoM_Adapter
and https://github.com/BHoM/BHoM_Adapter/projects/1 for the full refactoring plan.