Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silent email address trim #848

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

steve-lebleu
Copy link

Just apply a trim on the email input value in a reusable way.

Copy link
Member

@qgerome qgerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do no think it's a good idea to expose this type to the frontend as it exposes a backend processing to the frontend part.

Let's go to a basic solution of .strip() in the login() mutation first.

@qgerome
Copy link
Member

qgerome commented Nov 15, 2024

Also, I think you do not have the pre-commit installed for the repo.

Copy link
Member

@qgerome qgerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, could you write a test for this please ?

@steve-lebleu
Copy link
Author

I reverted the first implementation which was quite unfair in favor of existing string utils, alreday unit tested. And just wrote an additional UT on the login endpoint to validate the integration of the util.

Copy link
Member

@qgerome qgerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is cleanup to do in your PR.

  • You can remove the schema.py change
  • There are commented lines that should be deleted

Otherwise, it's good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants