Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the spot_detection_2d tool and add support for single-image processing #132

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Sep 24, 2024

Bildschirmfoto 2024-09-24 um 16 43 10

cc @rmassei

There are a few breaking changes here, mostly because I could not comprehend what the original code was doing in several cases. The new version relies on blob detection filters from skimage.feature and supports the LoG, DoG, and DoH detectors. Besides, the columns of the TSV output file have changed to lower-case, and the TSV now also includes scale and radius columns.


FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

@kostrykin
Copy link
Member Author

kostrykin commented Sep 24, 2024

There is a really weird issue with the first test.

When running in planemo test, the test data input1.tif is loaded as an image with shape (198, 356) (which is wrong, because it should be (5, 198, 356)). When running the same script with the command line copy & pasted from the test results report, in the same Conda environment created by planemo, the image is correctly recognized as (5, 198, 356).

I'm stuck with this at the moment.
Workaround added in bc288c4

@kostrykin
Copy link
Member Author

kostrykin commented Sep 24, 2024

The tool produces a tabular list of detections.

This list can then be rasterized using the new version of the points2binaryimage tool: #133

After rasterization:

  • Visualization can be performed using the Overlay images tool (segmentation contours over image).
  • Feature extraction should also be possible using the Extract 2D features tool.

@rmassei Please feel free to review this and #133.

@kostrykin kostrykin merged commit f1b9207 into BMCV:master Sep 25, 2024
10 checks passed
@kostrykin kostrykin deleted the spot_detection_2d/dev branch September 25, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants