Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept tiff input data in scale_image tool #138

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Oct 16, 2024

The scale_image tool was only accepting PNG files:

<param name="input" type="data" format="png" label="Image file"/>

Strangely, there already were tests for TIFF files and they passed despite the format="png" attribute:

<param name="input" value="input2_normalized.tiff"/>

Is this a bug in the testing framework?

This PR fixes the format attribute so that TIFF files are also accepted (tests are already there).

cc @dianichj


FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

@kostrykin kostrykin merged commit c55311b into BMCV:master Oct 17, 2024
10 checks passed
@kostrykin kostrykin deleted the dev/scale_image branch October 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant