Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote_repository_url of color_deconvolution tool #139

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

kostrykin
Copy link
Member

Fix remote_repository_url of color_deconvolution tool.

I wasn't sure whether it's worth incrementing the version for such a small change. On the other hand, it's nice to have the remote_repository_url set correctly.


FOR THE CONTRIBUTOR — Please fill out if applicable

Please make sure you have read the CONTRIBUTING.md document (last updated: 2024/04/23).

  • License permits unrestricted use (educational + commercial).

If this PR adds or updates a tool or tool collection:

Also rename: color-deconvolution.xml -> color_deconvolution.xml
@bgruening
Copy link
Collaborator

I would not bump. Its a cosmetic change that triggers all kind of updates on Galaxy deployments.

@kostrykin
Copy link
Member Author

kostrykin commented Oct 16, 2024

I understand. Is it fine to merge with the old version, so this will not be forgotten in the next substantial update? After I will have fixed the tests.

@kostrykin kostrykin marked this pull request as draft October 16, 2024 17:09
@bgruening
Copy link
Collaborator

Yes, I would merge and stop the CI job. Or merge with [ci skip].

@kostrykin kostrykin marked this pull request as ready for review October 17, 2024 11:34
@kostrykin kostrykin merged commit 07aba15 into BMCV:master Oct 17, 2024
10 checks passed
@kostrykin kostrykin deleted the dev/color_deconvolution branch October 17, 2024 11:35
@bgruening
Copy link
Collaborator

Lets add next time a profile version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants