Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disables generation of pyramids for output formats which do not support pyramids in bfconvert tool #69

Merged
merged 4 commits into from
Aug 30, 2023
Merged

disables generation of pyramids for output formats which do not support pyramids in bfconvert tool #69

merged 4 commits into from
Aug 30, 2023

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Aug 12, 2023 •
edited
Loading

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@kostrykin
fixes planemo lint for the bfconvert tool
d528a2d
@kostrykin
adds Default for pyramid_options in bfconvert
52d52ec 
Adds the option `Default` for `pyramid_options` in the `bfconvert` tool, which translates to either `Generate Pyramid` or `No Pyramid` based on the selected output format (e.g., PNG does not support pyramids). The selection is based on the list of formats which support pyramids:

<https://docs.openmicroscopy.org/bio-formats/6.7.0/supported-formats.html>
@kostrykin
merges options pyramid_options in bfconvert
ec81e6e 
The options `Default` and `Generate Pyramid` are replaced by a single option (called `Generate Pyramid`, which works like `Default`).
@kostrykin
increments version of the bfconvert tool
6bd6644
kostrykin referenced this pull request Aug 12, 2023
@alliecreason
update version, add tests for ome.tiff and pyramid
694ef74
@kostrykin
Copy link
Member Author

@alliecreason Kind reminder to please check whether the changes of this PR are fine from your side :)

@kostrykin kostrykin marked this pull request as ready for review August 24, 2023 14:45
@bgruening
Copy link
Collaborator

Danke.

A few people have an interest in a galaxy-imaging Matrix channel, so I have created one. Maybe you want to join: https://matrix.to/#/#galaxyproject_imaging:matrix.org

@bgruening bgruening merged commit e27798c into BMCV:master Aug 30, 2023
10 checks passed
@kostrykin kostrykin deleted the bfconvert branch August 30, 2023 13:09
@kostrykin kostrykin mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostrykin @bgruening