Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stratagem limit causing validation error #236

Closed
GMTemplar opened this issue May 11, 2022 · 3 comments
Closed

Stratagem limit causing validation error #236

GMTemplar opened this issue May 11, 2022 · 3 comments
Labels
bug Something isn't working Catalog Issue Stuff wrong with catalog not data

Comments

@GMTemplar
Copy link

Describe the bug
Stratagems cause a validation error even when the limit set is not exceeded.

To Reproduce
Steps to reproduce the behavior:

  1. Setup a list of 1750 and limit the number of Stratagems Points to 5.
  2. Add a maniple to the force.
  3. Choose 5 points worth of stratagems.
  4. See error "...has spent 1 Stratagem points too much from Stratagem (maximum 4 stratagem points)."

Expected behavior
Validation error should not occur when value of chosen stratagems does not exceed the limit set.

Device and data (please complete the following information):

  • Windows
  • BattleScribe version v2.03.21.166

Additional context
Assuming opponent plays with single Legio rules, you will choose 5 or 6 stratagems to a 1750 list depending how you read the table in rulebook. In both cases this would currently cause a validation error when the limit is set to 5/6.

@GMTemplar GMTemplar added the bug Something isn't working label May 11, 2022
@jorisvangestel
Copy link
Collaborator

jorisvangestel commented May 15, 2022

Yeah the matched play SP limit is build into the 'Stratagem Points' category in in the data. That this is a thing is completely unclear in the app, and setting a custom SP limit will cause your issue when going past this build in limit.

Reading the rule book, Stratagem Points can vary based on the mission in matched play, but will also potentially be different based on the # of maniples your opponent takes and a potential points difference. Even if that wasn't the case it is clearly very confusing and inter-plays badly with the custom SP limits you can set on a roster (e.g. it also doesn't work if you are building a list for open play and decide on any other number of SP).

For now the easiest approach would be to simply remove this build in limit. A better solution would be something similar to how the 40k repo handles CP, having a separate 'game configuration' section in which you select a battle size/game type etc which initialize a SP limit, possibly an option to select # of maniples your opponent is using and a point difference etc.

@zopha zopha added the Catalog Issue Stuff wrong with catalog not data label Aug 16, 2023
@GMTemplar
Copy link
Author

The SP limit should definitely be removed entirely. Pretty much everyone plays with Stratagem hand instead of point limit now as per Matched Play Guide. If someone really wants to use the old way of doing it, I'm sure they can handle counting to five. As it stands now, it doesn't work and it won't be missed.

@jorisvangestel
Copy link
Collaborator

This issue has been solved as we replaced the stratagem section with the stratagem hand and a selector for the battlesize. If you still want a stratagem point on your list you can set it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Catalog Issue Stuff wrong with catalog not data
Projects
None yet
Development

No branches or pull requests

3 participants