Merge pull request #295 from 06wj/master

Add option to toggle GLSL preprocess
BabylonJS · Jan 2, 2024 · 8250ccd · 8250ccd
2 parents 77da612 + 6fb9107
commit 8250ccd
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -33,6 +33,9 @@
     "build": "run-s build:tslint build:bundle build:copybuild:copy:bundle build:concatBundleFunc -n",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
+  "dependencies": {
+    "@shaderfrog/glsl-parser": "^2.0.1"
+  },
   "devDependencies": {
     "@types/webxr": "^0.5.1",
     "concat-cli": "^4.0.0",

diff --git a/src/embeddedFrontend/resultView/resultView.ts b/src/embeddedFrontend/resultView/resultView.ts
@@ -186,6 +186,11 @@ export class ResultView {
             state.beautify = (sourceCodeState.sender as HTMLInputElement).checked;
             this.mvx.updateState(this.sourceCodeComponentStateId, state);
         });
+        this.sourceCodeComponent.onPreprocessChanged.add((sourceCodeState) => {
+            const state = this.mvx.getGenericState<ISourceCodeState>(this.sourceCodeComponentStateId);
+            state.preprocessed = (sourceCodeState.sender as HTMLInputElement).checked;
+            this.mvx.updateState(this.sourceCodeComponentStateId, state);
+        });
 
 
         this.updateViewState();

diff --git a/src/embeddedFrontend/resultView/sourceCode/sourceCodeComponent.ts b/src/embeddedFrontend/resultView/sourceCode/sourceCodeComponent.ts
@@ -1,5 +1,7 @@
+import preprocess from "@shaderfrog/glsl-parser/preprocessor"; // tslint:disable-line:no-submodule-imports
 import { BaseComponent, IStateEvent } from "../../mvx/baseComponent";
 import { ISourceCodeChangeEvent } from "../resultView";
+import { Logger } from "../../../shared/utils/logger";
 
 export interface ISourceCodeState extends ISourceCodeChangeEvent {
     nameVertex: string;
@@ -8,6 +10,7 @@ export interface ISourceCodeState extends ISourceCodeChangeEvent {
     translated: boolean;
     editable: boolean;
     beautify: boolean;
+    preprocessed: boolean;
 }
 
 // Declare Ace types here.
@@ -43,6 +46,7 @@ export class SourceCodeComponent extends BaseComponent<ISourceCodeState> {
     public onSourceCodeCloseClicked: IStateEvent<ISourceCodeState>;
     public onSourceCodeChanged: IStateEvent<ISourceCodeState>;
     public onBeautifyChanged: IStateEvent<ISourceCodeState>;
+    public onPreprocessChanged: IStateEvent<ISourceCodeState>;
 
     private editor: IAceEditor;
 
@@ -55,6 +59,7 @@ export class SourceCodeComponent extends BaseComponent<ISourceCodeState> {
         this.onSourceCodeCloseClicked = this.createEvent("onSourceCodeCloseClicked");
         this.onSourceCodeChanged = this.createEvent("onSourceCodeChanged");
         this.onBeautifyChanged = this.createEvent("onBeautifyChanged");
+        this.onPreprocessChanged = this.createEvent("onPreprocessChanged");
     }
 
     public showError(errorMessage: string) {
@@ -86,33 +91,50 @@ export class SourceCodeComponent extends BaseComponent<ISourceCodeState> {
     public render(state: ISourceCodeState, stateId: number): Element {
         const source = state.fragment ? state.sourceFragment : state.sourceVertex;
         let originalShader: string;
+        let preprocessed = state.preprocessed;
+
         // tslint:disable-next-line:prefer-conditional-expression
         if (state.translated) {
             originalShader = state.fragment ? state.translatedSourceFragment : state.translatedSourceVertex;
+            preprocessed = false;
         }
         else {
             originalShader = source ?? "";
         }
 
-        const displayedShader = state.beautify ? this._indentIfdef(this._beautify(originalShader)) : originalShader;
+        let displayedShader = originalShader;
+        if (preprocessed) {
+            try {
+                displayedShader = preprocess(displayedShader, {
+                    preserveComments: false,
+                    stopOnError: true
+                });
+            } catch (e) {
+                Logger.error("shader preprocess failed", e);
+            }
+        }
+
+        if (state.beautify) {
+            displayedShader = this._indentIfdef(this._beautify(displayedShader));
+        }
 
         const htmlString = this.htmlTemplate`
         <div class="sourceCodeComponentContainer">
             <div class="sourceCodeMenuComponentContainer">
                 <ul class="sourceCodeMenuComponent">
-                    $${ state.translatedSourceVertex ? this.htmlTemplate`<li><a class="${!state.fragment && state.translated ? "active" : ""}" href="#" role="button" commandName="onTranslatedVertexSourceClicked">Translated Vertex</a></li>` : "" }
-                    $${ state.translatedSourceFragment ? this.htmlTemplate`<li><a class="${state.fragment && state.translated ? "active" : ""}" href="#" role="button" commandName="onTranslatedFragmentSourceClicked">Translated Fragment</a></li>` : "" }
+                    $${state.translatedSourceVertex ? this.htmlTemplate`<li><a class="${!state.fragment && state.translated ? "active" : ""}" href="#" role="button" commandName="onTranslatedVertexSourceClicked">Translated Vertex</a></li>` : ""}
+                    $${state.translatedSourceFragment ? this.htmlTemplate`<li><a class="${state.fragment && state.translated ? "active" : ""}" href="#" role="button" commandName="onTranslatedFragmentSourceClicked">Translated Fragment</a></li>` : ""}
                     <li><a class="${!state.fragment && !state.translated ? "active" : ""}" href="#" role="button" commandName="onVertexSourceClicked">Vertex</a></li>
                     <li><a class="${state.fragment && !state.translated ? "active" : ""}" href="#" role="button" commandName="onFragmentSourceClicked">Fragment</a></li>
                     <li><a href="#" role="button" commandName="onSourceCodeCloseClicked">Close</a></li>
                 </ul>
             </div>
-            $${
-            this.htmlTemplate`<div class="sourceCodeComponent">${displayedShader}</div>`
+            $${this.htmlTemplate`<div class="sourceCodeComponent">${displayedShader}</div>`
             }
             <div class="sourceCodeMenuComponentFooter">
                 <p>
                     <label><input type="checkbox" commandName="onBeautifyChanged" ${state.beautify ? "checked" : ""} /> Beautify</label>
+                    <label><input type="checkbox" commandName="onPreprocessChanged" ${state.preprocessed ? "checked" : ""} /> Preprocess</label>
                 </p>
             </div>
         </div>`;