Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual scroll-to comment indicator #73

Merged
merged 3 commits into from
May 18, 2024

Conversation

BagToad
Copy link
Owner

@BagToad BagToad commented May 18, 2024

Highlight the comment being scrolled to make it easier to see what comment you are scrolling to.

This PR also addresses an issue where the scroll-to comment could have sent multiple responses to the background script/popup script, making one of the messages return an exception.

Closes #63

BagToad added 3 commits May 18, 2024 08:36
Related to #63

Implements visual feedback for scrolled-to comments in Zendesk Link Collector extension.
- Adds a new function `highlightComment` to apply a temporary highlight to a comment after scrolling to it.
- Modifies the `scrollToComment` function to call `highlightComment`, providing a visual indication of the scrolled-to comment.
- Ensures the highlight fades away after a few seconds, improving user experience by clearly indicating the comment of interest.
…to comment function to prevent duplicate messages
@BagToad BagToad self-assigned this May 18, 2024
@BagToad BagToad merged commit dfad544 into main May 18, 2024
3 checks passed
@BagToad BagToad deleted the dev-bagtoad-visual-scroll-indicator branch May 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant