Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final group capstone - Rent a car #20

Merged
merged 42 commits into from
Aug 2, 2023
Merged

Final group capstone - Rent a car #20

merged 42 commits into from
Aug 2, 2023

Conversation

BahirHakimy
Copy link
Owner

@BahirHakimy BahirHakimy commented Jul 30, 2023

In this project I have implemented the following requirements.

We are two partners in this project @BahirHakimy @Dadadon .

Core requirements implemented

  • Initialized the project with Postgresql as database and React js as frontend.
  • Added navigation bar with the following links
    • "Cars" List.
    • "Reserve" form.
    • "My reservations".
    • "Add Car" (the link is visible to everybody).
    • "Delete Car" (the link is visible to everybody).
  • Create the database tables according to this diagram
  • On the main page, the user can see a list of Cars.
  • When the user selects a specific item, they can see the details page with its full description (skip the "Rotate image" button).
  • In the details page, the user can click the "Reserve" button (in the design you can see the "Configure" button - please replace it with the "Reserve" button).
  • When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.
  • Made the app responsive, creating both mobile and desktop versions.

Optional requirements implemented

  • Implemented proper token-based authentication in both frontend and backend.
  • When the user clicks the "Delete item" link in the navigation panel they can see a list of all items with title and "Delete" button.
  • When the user clicks the "Delete" button, the selected item is marked as removed and does not show on the main list anymore.

Additional features

  • Added toast message
  • Added beautiful animations using Lottiefiles

Page previews

  • Login and Register

    • image

    • Mobile view

      • image
  • Cars List

    • image

    • Mobile view

      • image
  • Car Detail

    • image
  • Add Car

    • image
  • Delete Car

    • image
  • Under Development Page

    • image
  • NotFound Page

    • image

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi STUDENT,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


README.md Outdated
Comment on lines 115 to 117
```bash
rspec spec/
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When I run the tests according to your instructions. this happens:

image

This is because rspec has not been included in the gemfile and because the spec folder does not exist.

Either kindly add some tests, or remove these instructions to prevent confusion.

  • OPTIONAL: Include some unit tests. In the industry, we write tests every day for each feature implemented.

README.md Outdated
Comment on lines 107 to 109
```bash
./bin/dev
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When I run the project according to your instructions, I get this:

image

  1. Is tailwindcss included in package.json dependencies? If not, kindly include it so your users have all the dependencies.

  2. Are there any more procedures required to run your project correctly other than those included on your readme? If that's the case, kindly add the instructions to your readme. Please, ensure any user can setup and run your project just by following your instructions.

note: This means I wasn't able to check your project's functionality and styling. This will be taken a look at the next review.

README.md Outdated
Comment on lines 94 to 101
### Install

To install the dependencies run the following command

```bash
bundle install
npm install
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly, include in your instructions the required db commands that your users will need to run your backend app: rails db:create, rails db:migrate, rails db:seed. 👍

Comment on lines +167 to +169
## 🙏 Acknowledgments <a name="acknowledgements"></a>

I would like to thank Microverse for helping me in my journey to become a Fullstack developer 🌹

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Therefore, in the Acknowledgments section, please give proper credit to the design's author, as required. 👍

import { store } from './context/store';
import Router from './Router';

function App() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please, kindly refactor this main App functional component to ES6 arrow function, so your code complies with the latest standards.

Refactoring is easy:

const App = () => {
  // ...
}

Explanation

The function keyword has been soft deprecated in almost all the software industry in favor of ES6 arrow functions. This means, almost nobody uses it anymore, so much that it's considered a non-best practice.

  • OPTIONAL: Refactor to ES6 there rest of the functions.

You can do a search in Vscode for the "function" word, and correct as needed. Shouldn't take you more than 5-10 min so don't worry:

image

That way, your code will meet the latest standards. 💪

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BahirHakimy,

Wow, you did it 🎉

Brilliant

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

applause

To highlight

  • All review comments have been implemented✔️
  • The project works well✔️
  • Beautiful, gorgeous frontend✔️
  • Nice job ✔️

Cheers and Happy coding!👏👏👏


@BahirHakimy BahirHakimy merged commit 4d7d00d into main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants