-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final group capstone - Rent a car #20
Conversation
[3pt] Navigation Panel #2
Setup database
[2pt] Authentication
[4pt] Details Page, [5pt] Main Page Cars list
Cars endpoint and reservation endpoint
Add Car, Responsiveness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi STUDENT,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
README.md
Outdated
```bash | ||
rspec spec/ | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I run the tests according to your instructions. this happens:
This is because rspec
has not been included in the gemfile
and because the spec
folder does not exist.
Either kindly add some tests, or remove these instructions to prevent confusion.
- OPTIONAL: Include some unit tests. In the industry, we write tests every day for
each
feature implemented.
README.md
Outdated
```bash | ||
./bin/dev | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I run the project according to your instructions, I get this:
-
Is tailwindcss included in package.json dependencies? If not, kindly include it so your users have all the dependencies.
-
Are there any more procedures required to run your project correctly other than those included on your readme? If that's the case, kindly add the instructions to your readme. Please, ensure any user can setup and run your project just by following your instructions.
note: This means I wasn't able to check your project's functionality and styling. This will be taken a look at the next review.
README.md
Outdated
### Install | ||
|
||
To install the dependencies run the following command | ||
|
||
```bash | ||
bundle install | ||
npm install | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Kindly, include in your instructions the required db commands that your users will need to run your backend app:
rails db:create, rails db:migrate, rails db:seed
. 👍
## 🙏 Acknowledgments <a name="acknowledgements"></a> | ||
|
||
I would like to thank Microverse for helping me in my journey to become a Fullstack developer 🌹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- According to the project requirements:
Therefore, in the Acknowledgments section, please give proper credit to the design's author, as required. 👍
app/javascript/application.js
Outdated
import { store } from './context/store'; | ||
import Router from './Router'; | ||
|
||
function App() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, kindly refactor this main
App
functional component to ES6 arrow function, so your code complies with the latest standards.
Refactoring is easy:
const App = () => {
// ...
}
Explanation
The function
keyword has been soft deprecated in almost all the software industry in favor of ES6 arrow functions. This means, almost nobody uses it anymore, so much that it's considered a non-best practice.
- OPTIONAL: Refactor to ES6 there rest of the functions.
You can do a search in Vscode for the "function" word, and correct as needed. Shouldn't take you more than 5-10 min so don't worry:
That way, your code will meet the latest standards. 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BahirHakimy,
Wow, you did it 🎉
Thank you for the changes implemented 💪 🥇 ㊗️
Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩
You are about to finish the Microverse program. You have come a long way!!!
Good luck in the software industry!! I'll see you there. ✨
Congratulations!!!!!! 🎉
To highlight
- All review comments have been implemented✔️
- The project works well✔️
- Beautiful, gorgeous frontend✔️
- Nice job ✔️
Cheers and Happy coding!👏👏👏
In this project I have implemented the following requirements.
We are two partners in this project @BahirHakimy @Dadadon . ❗
Core requirements implemented
Optional requirements implemented
Additional features
Page previews
Login and Register
Mobile view
Cars List
Mobile view
Car Detail
Add Car
Delete Car
Under Development Page
NotFound Page