Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate DMs sent on claim from web #273

Open
tescher opened this issue Dec 23, 2022 · 0 comments
Open

Duplicate DMs sent on claim from web #273

tescher opened this issue Dec 23, 2022 · 0 comments

Comments

@tescher
Copy link
Collaborator

tescher commented Dec 23, 2022

Describe the bug
When a bounty is claimed on the web side, 2 direct messages are sent to the bounty creator on the bot side.

Expected behavior
Only one claimed DM should be sent

Additional context
This is happening because when a bounty is claimed, 2 database updates occur:

  • On the web side the data elements to claim it are updated
  • On the bot side the BountyUtils.bountyCleanUp is called which replaces the document with updated iconUrls

The replace update needs to be ignored, probably, but it should be conditional on coming from this routine, otherwise if we do a replace for some other reason on the web side, it won't get caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant