Handle DM problems better, notify the assigned user when bounty is created #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tescher
added a commit
that referenced
this pull request
Jun 20, 2023
* Update Develop from Main (#91) * Develop (#78) * feat: notify claimant * chore: more elaborate dm message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Develop (#79) * feat: notify claimant * chore: more elaborate dm message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Modals on the bot (#81) * Frist try * Interim commit * Interim commit * Fix ephemerals * Modal for application pitch * Interim save * Interim commit * Interim * Interim * Start of ClientSync cleanup * Clean up console.logs * Fix application bounty title and timeout message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Updated tag functionality (#93) * feat: display tags on bounty * feat: more list command options * chore: changed tags data type * fix: bounty channel category * chore: query if indexed * add multiple tags * limit displayable tags * add channel category options * bounty list db query * Add tags to create modal * Attempt to fix list refresh error on web updates * Try again fixing list display after web edit * Limite tag entry to one line * ... if too many tags to display * Fixes from PR review --------- Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Submit notes in modal (#94) * feat: display tags on bounty * feat: more list command options * chore: changed tags data type * fix: bounty channel category * chore: query if indexed * add multiple tags * limit displayable tags * add channel category options * bounty list db query * Add tags to create modal * Attempt to fix list refresh error on web updates * Try again fixing list display after web edit * Limite tag entry to one line * ... if too many tags to display * Fixes from PR review * Submit notes in modal * Remove old stuff * Fix crypto include --------- Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Bump http-cache-semantics from 4.1.0 to 4.1.1 (#95) * Develop (#78) * feat: notify claimant * chore: more elaborate dm message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Develop (#79) * feat: notify claimant * chore: more elaborate dm message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Modals on the bot (#81) * Frist try * Interim commit * Interim commit * Fix ephemerals * Modal for application pitch * Interim save * Interim commit * Interim * Interim * Start of ClientSync cleanup * Clean up console.logs * Fix application bounty title and timeout message * Update Develop from Main (#91) (#92) * Develop (#78) * feat: notify claimant * chore: more elaborate dm message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Develop (#79) * feat: notify claimant * chore: more elaborate dm message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Modals on the bot (#81) * Frist try * Interim commit * Interim commit * Fix ephemerals * Modal for application pitch * Interim save * Interim commit * Interim * Interim * Start of ClientSync cleanup * Clean up console.logs * Fix application bounty title and timeout message Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> * Bump http-cache-semantics from 4.1.0 to 4.1.1 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: tescher <tim@eschers.com> Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Don't try to split null tags (#97) * Hotfix for IOU into main (#98) (#99) * Update Develop from Main (#91) * Develop (#78) * feat: notify claimant * chore: more elaborate dm message * Develop (#79) * feat: notify claimant * chore: more elaborate dm message * Modals on the bot (#81) * Frist try * Interim commit * Interim commit * Fix ephemerals * Modal for application pitch * Interim save * Interim commit * Interim * Interim * Start of ClientSync cleanup * Clean up console.logs * Fix application bounty title and timeout message * Updated tag functionality (#93) * feat: display tags on bounty * feat: more list command options * chore: changed tags data type * fix: bounty channel category * chore: query if indexed * add multiple tags * limit displayable tags * add channel category options * bounty list db query * Add tags to create modal * Attempt to fix list refresh error on web updates * Try again fixing list display after web edit * Limite tag entry to one line * ... if too many tags to display * Fixes from PR review --------- * Submit notes in modal (#94) * feat: display tags on bounty * feat: more list command options * chore: changed tags data type * fix: bounty channel category * chore: query if indexed * add multiple tags * limit displayable tags * add channel category options * bounty list db query * Add tags to create modal * Attempt to fix list refresh error on web updates * Try again fixing list display after web edit * Limite tag entry to one line * ... if too many tags to display * Fixes from PR review * Submit notes in modal * Remove old stuff * Fix crypto include --------- * Bump http-cache-semantics from 4.1.0 to 4.1.1 (#95) * Develop (#78) * feat: notify claimant * chore: more elaborate dm message * Develop (#79) * feat: notify claimant * chore: more elaborate dm message * Modals on the bot (#81) * Frist try * Interim commit * Interim commit * Fix ephemerals * Modal for application pitch * Interim save * Interim commit * Interim * Interim * Start of ClientSync cleanup * Clean up console.logs * Fix application bounty title and timeout message * Update Develop from Main (#91) (#92) * Develop (#78) * feat: notify claimant * chore: more elaborate dm message * Develop (#79) * feat: notify claimant * chore: more elaborate dm message * Modals on the bot (#81) * Frist try * Interim commit * Interim commit * Fix ephemerals * Modal for application pitch * Interim save * Interim commit * Interim * Interim * Start of ClientSync cleanup * Clean up console.logs * Fix application bounty title and timeout message * Bump http-cache-semantics from 4.1.0 to 4.1.1 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... --------- * Don't try to split null tags (#97) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added ELI5DAO to customer list (#100) * Feature/readme into Develop (#103) * Initial * Typos * Move to top directory * Move to top dir * Add images directory * Add images for readme * Add intents image * Add bot permissions * Update README.md * More Mongo changes * URL update * Update discord js to 13.14 to fix API bug (#104) * Handle DM problems better, notify the assigned user when bounty is created (#108) * Handle DM problems better, notify the assigned user about their bounty when created * Clean up comments * Repeating Bounties (#106) * Adding fields to model, template creation. * Modify card titles, filter templates from list command * Added in cron job, creation from templates, checking if command is tried on template * Handle deleting the template bounty, fix background publishing error * Clean up * Leave old console.log in * Handle IOUs, delete previous instance if not claimed, improve messaging * Add end dates/max repeats * Add cron logic for ending repeats * Various fixes * Tag and Channel Category listings now appear in channel rather than DM * Some more cleanup * Remove template data from repeat --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mofejesu1 <Mofejesuadesinapaul22@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when DMs had to be sent to a user (e.g. the assignee of a bounty), if the DM failed because the user had the bot blocked, a message would be posted to the default bounty channel. The problem was that was done too late in the flow and much of the message context was missing, including the ability to correctly tag the recipient.
Now a new routine DiscordUtils.attemptDM attempts the DM, and if it fails, prepends the message content with a "kicker" tagging the user and posting the content in the default bounty channel.
Also, when a bounty is created with "for-user" set, the Assign activity is called instead of just setting the bounty.assignTo immediately. That way the assignedTo user gets notified.
Fixes issues #64 and #107