Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write test for Player::copyFrom #229

Open
BarthPaleologue opened this issue Dec 19, 2024 · 0 comments
Open

Write test for Player::copyFrom #229

BarthPaleologue opened this issue Dec 19, 2024 · 0 comments
Labels
good first issue Good for newcomers maintenance

Comments

@BarthPaleologue
Copy link
Owner

The Player class is brittle for some parts and testing would help catching future bugs.

The most important is to test copyFrom and ensure that it indeeds perform a deep-copy.

By testing this method, adding new fields to Player without updating copyFrom would result in a test failure of the deep-copy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BarthPaleologue