Exploration missions #144
Merged
Exploration missions #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CosmosJourneyer into SpaceStationsV2
so that they can be displayed in the info panel
+ make it much harder to desync player object between starmap, starsystemview and cosmosjourneyer objects. No reassignment is possible. If the same object is given at creation to the 3, it is then impossible to have a desync
each station can display its potential commercial partners and the interesting space phenomenons in the neighborhood
Jumping to the next system in the itinerary will set the next one as target automatically until the destination is reached
this will be useful to display all possible target systems
they still need to become targetable though
It will display infinity instead
+ make them hoverable + remove some old code
This will prevent cursor duplication
do not update the thruster plume when the throttle is zero (this showed up in the browser's profiler)
- disable plot itinerary button when selected system is current system - fix shorthand ui not displaying on current system when selected - fix selection cursor overlapping with current system cursor - removed dead code
This new version is better as it no longer requires looping over all orbital objects, which will prevent errors if the objects are not always generated in the same sequence. This will be necessary for quest generation
this will fix invalid state when loading a save
Having multiple mission classes implementing the mission interface would prove challenging for serialization and deserialization. This is also in conflict with deserialization of the mission tree. To avoid these issues, all missions will be of the same class and deserialization will only rely on deserializing the tree and metadata.
each node describes itself, which simplifies greatly the system
this allows to check equality between 2 mission trees. States are not taken into account. It the same tasks are required the 2 missions are equal
BarthPaleologue
force-pushed
the
SpaceStationsV2
branch
from
e1b6eec
to
5f45c91
Compare
No need to split
+ green color when mission is completed
Developping the new universe object id system earlier showed some limits. Systems were identified by their seed. The issue is that excludes custom star systems from interacting with the engine in the same way as seeded systems. To fix this issue, star system coordinates are implemented by all types of star system models. It is easy to generate them from a seed and they can be hardcoded for custom systems. This is future proof for the save file. Right now, there is no good way to get the system model from the coordinates of a custom system, but a global registry could be used.
As with the previous commit the aim to use seeds only when absolutely necessary This commit removes almost all checks with SeededStarSystemModel by a getter function that returns the correct model, be it seeded or custom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step toward actual gameplay in Cosmos Journeyer.
It adds the first exploration missions. They are generated at space stations and change every hour. Rewards are calculated on the distance to travel.
Missions
More will come with new destinations and new gameplay.
Additional changes
And much more!