Fixed many issues #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
BarthPaleologue
commented
Dec 2, 2023
BarthPaleologue
commented
- Fixed procedural textures crashing clouds and rings
- Improved glsl include system
- Fixed potential WebGPU errors
glsl modules now just work by simple copy of the source code, which enables to ditch struct uniforms, which will be necessary for WebGPU
See https://forum.babylonjs.com/t/texture-sampler-and-non-uniform-control-flow/46084/2 for discussion and solution. TLDR: advanced shaders need non uniform control flow for textures samplers and added a comment at the top of the glsl disable the checks
Setting each element by string made WebGPU crash. By using the setFloatArray method, we can achieve the expected behavior without crashing WebGPU
Shader code will be added to the store only when an object requiring it is created. This will ease the debug process and makes the code cleaner.
To understand, refer to this discussion: https://forum.babylonjs.com/t/webgl-warning-when-binding-procedural-texture-to-postprocess/46047 On chromium browsers, in some rare cases, the procedural textures would be binded before they were rendered, causing undefined behavior.
Creating them before updating the positions would create associated procedural textures. They render the scene to init themselves, so we don't want the update code to run before the bodies are well positioned
BarthPaleologue
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.