-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed many issues #2
Merged
Merged
Commits on Dec 1, 2023
-
Ditched glslify for a simpler approach
glsl modules now just work by simple copy of the source code, which enables to ditch struct uniforms, which will be necessary for WebGPU
Configuration menu - View commit details
-
Copy full SHA for dcf4340 - Browse repository at this point
Copy the full SHA dcf4340View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81eed3b - Browse repository at this point
Copy the full SHA 81eed3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5611d6c - Browse repository at this point
Copy the full SHA 5611d6cView commit details -
Disabled uniform analysis on some shaders
See https://forum.babylonjs.com/t/texture-sampler-and-non-uniform-control-flow/46084/2 for discussion and solution. TLDR: advanced shaders need non uniform control flow for textures samplers and added a comment at the top of the glsl disable the checks
Configuration menu - View commit details
-
Copy full SHA for 90ebf5f - Browse repository at this point
Copy the full SHA 90ebf5fView commit details -
Setting each element by string made WebGPU crash. By using the setFloatArray method, we can achieve the expected behavior without crashing WebGPU
Configuration menu - View commit details
-
Copy full SHA for 0cf88e7 - Browse repository at this point
Copy the full SHA 0cf88e7View commit details -
Prevented shader code side effect
Shader code will be added to the store only when an object requiring it is created. This will ease the debug process and makes the code cleaner.
Configuration menu - View commit details
-
Copy full SHA for da7deb9 - Browse repository at this point
Copy the full SHA da7deb9View commit details -
To understand, refer to this discussion: https://forum.babylonjs.com/t/webgl-warning-when-binding-procedural-texture-to-postprocess/46047 On chromium browsers, in some rare cases, the procedural textures would be binded before they were rendered, causing undefined behavior.
Configuration menu - View commit details
-
Copy full SHA for 020539a - Browse repository at this point
Copy the full SHA 020539aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06825c4 - Browse repository at this point
Copy the full SHA 06825c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0f3496 - Browse repository at this point
Copy the full SHA f0f3496View commit details
Commits on Dec 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b28593b - Browse repository at this point
Copy the full SHA b28593bView commit details -
Creating them before updating the positions would create associated procedural textures. They render the scene to init themselves, so we don't want the update code to run before the bodies are well positioned
Configuration menu - View commit details
-
Copy full SHA for 4af75e2 - Browse repository at this point
Copy the full SHA 4af75e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6882556 - Browse repository at this point
Copy the full SHA 6882556View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.