OrbitCamera has better sensitivity

BarthPaleologue · Sep 26, 2023 · aaf7cfa · aaf7cfa
1 parent 2d06abf
commit aaf7cfa
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/core/Transform.cpp b/core/Transform.cpp
@@ -7,7 +7,7 @@
 
 Transform::Transform() {}
 
-void Transform::setPositionFromFloats(float x, float y, float z) {
+void Transform::setPosition(float x, float y, float z) {
     _position->x = x;
     _position->y = y;
     _position->z = z;

diff --git a/core/Transform.h b/core/Transform.h
@@ -20,7 +20,7 @@ class Transform {
 
     glm::vec3 getLeftDirection();
 
-    void setPositionFromFloats(float x, float y, float z);
+    void setPosition(float x, float y, float z);
 
     void translate(glm::vec3 displacement);
 

diff --git a/core/cameras/Camera.cpp b/core/cameras/Camera.cpp
@@ -9,7 +9,7 @@ Camera::Camera(Engine *engine) : Transform(), _engine(engine) {
     glfwGetWindowSize(_engine->getWindow(), &width, &height);
     setAspectRatio(static_cast<float>(width) / static_cast<float>(height));
 
-    setPositionFromFloats(0.0f, 0.0f, 7.0f);
+    setPosition(0.0f, 0.0f, 7.0f);
     setNear(0.1);
     setFar(80.1);
 

diff --git a/core/cameras/OrbitCamera.cpp b/core/cameras/OrbitCamera.cpp
@@ -16,8 +16,8 @@ OrbitCamera::OrbitCamera(Engine *engine) : Camera(engine), _target(0.0f), _radiu
 
     engine->onMouseMoveObservable.add([this](double mouseDX, double mouseDY) {
         if (!this->_engine->isMousePressed()) return;
-        this->rotatePhi(-(float) mouseDX / 500.0f);
-        this->rotateTheta(-(float) mouseDY / 500.0f);
+        this->rotatePhi(-(float) mouseDX / 200.0f);
+        this->rotateTheta(-(float) mouseDY / 200.0f);
     });
 }
 

diff --git a/core/meshes/Cube.cpp b/core/meshes/Cube.cpp
@@ -5,7 +5,7 @@
 #include "Cube.h"
 
 Cube::Cube(const char *name, float x, float y, float z) : AbstractMesh(name) {
-    setPositionFromFloats(x, y, z);
+    setPosition(x, y, z);
     std::vector<float> vertices = {
             -1.0f, -1.0f, -1.0f,
             1.0f, -1.0f, -1.0f,

diff --git a/core/meshes/Triangle.cpp b/core/meshes/Triangle.cpp
@@ -5,7 +5,7 @@
 #include "Triangle.h"
 
 Triangle::Triangle(const char *name, float x, float y, float z) : AbstractMesh(name) {
-    setPositionFromFloats(x, y, z);
+    setPosition(x, y, z);
     std::vector<GLfloat> points = {
             0.0f, 0.5f, 0.0f,
             0.5f, -0.5f, 0.0f,

diff --git a/main.cpp b/main.cpp
@@ -19,7 +19,7 @@ int main() {
 
     Scene scene;
     OrbitCamera camera(&engine);
-    camera.setPositionFromFloats(0, 0, 20);
+    camera.setPosition(0, 0, 20);
     camera.setRadius(20.0);
     camera.rotateTheta(-3.0f);
     scene.setActiveCamera(&camera);