Removed blurhash dependency #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
renefloor
force-pushed
the
bugfix/remove-blurhash-dependency
branch
from
54ecab2
to
c2a488d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This removes the blur_hash OctoSet
Currently it's depending on blur_hash and blur_hash is broken on current master channel, see fluttercommunity/flutter_blurhash#57
As OctoImage is also used by other packages, such as CachedNetworkImage this also breaks those packages.
🆕 What is the new behavior (if this is a feature change)?
It removes the dependency on blur_hash and adds an explanation to the readme how to keep using it.
I would say that no included OctoSet should ever add external dependencies to keep this package clean and maintainable.
💥 Does this PR introduce a breaking change?
Yes, because we are removing an existing API.
🐛 Recommendations for testing
No recommendations, as we only remove some non-critical code.
📝 Links to relevant issues/docs
#29
🤔 Checklist before submitting