This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
PAA5100JE motion sensor code #85
Open
Leo246813
wants to merge
50
commits into
BeNeuroLab:main
Choose a base branch
from
Leo246813:Motion_sensor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtMostafa
reviewed
Aug 12, 2024
Version updated with no external library required; can put init_registers function to another file to reduce some lines of codes
AtMostafa
suggested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job, let me know when you've updated the PR
update 1
AtMostafa
suggested changes
Aug 23, 2024
AtMostafa
suggested changes
Aug 23, 2024
AtMostafa
reviewed
Sep 3, 2024
AtMostafa
suggested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job! let's try it out!
2 bugs found, needed to test
Leo246813
commented
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugged and found two possible errors:
- Polarity and phase incorrect when connect to SPI because different microcontroller is used (updated: polarity: 0; phase: 1)
- _read function may have read the wrong data before (need to test if data[0] or data[1] is correct)
initialization error 66 tried unplug and plug, maybe something to do with the hardware because the spi seems not to connect
Final version after testing: both sensors were successfully initialized and were able to read motion, however the read data were not send to the pyboard. A possible cause would be an error during the ISR, because no ID were provided by this sensor to allow it to perform an interrupt.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.