Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move video naming to the config #20

Open
bagibence opened this issue Nov 20, 2023 · 3 comments
Open

Move video naming to the config #20

bagibence opened this issue Nov 20, 2023 · 3 comments

Comments

@bagibence
Copy link
Member

Currently Jarvis saves things in a Recording_... folder, and we rename that to <session-name>_videos. But we might switch to something else for recording the videos, and they might be saved in another folder.

It was proposed that we should store the name of this folder in the config. @AtMostafa Is this what you meant?

I just realized that the renaming function doesn't care where the videos are stored currently because it looks for videos anywhere in the session, so that should not be necessary..

But it does make assumptions that:

  • the extension is .avi
  • files end with an underscore and the camera's ID (e.g. Camera_blabla_1.avi)

Putting the extension in the config (and giving it as an argument to rename_raw_videos_of_session) makes sense to me.

What about the name? Can we assume that it will end like this or should we find a more flexible way of figuring out the camera ID? Or just return to this problem if we switch away from Jarvis?

@bagibence
Copy link
Member Author

@gen21kawa any thoughts?

@gen21kawa
Copy link
Contributor

I think naming a video file as "Camera_{camera_id}.avi" is good for now. I don't think we will be switching from Jarvis anytime soon for video acquisition (video acquisition tool has been pretty stable), and other softwares would use similar naming convention.

@AtMostafa
Copy link
Member

maybe add the file names of the videos to the config file as well?! eg "?_!!.avi"
Also, I'd rename the videos to our convention M019_..._cam-id.avi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants