Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should an upload fail if some files are already there? #9

Open
bagibence opened this issue Oct 16, 2023 · 1 comment
Open

Should an upload fail if some files are already there? #9

bagibence opened this issue Oct 16, 2023 · 1 comment

Comments

@bagibence
Copy link
Member

Currently when calling upload_raw_session (which in turn calls upload_raw_behavioral_data, upload_raw_ephys_data, and upload_raw_videos), if a file already exists on the remote server, then the upload fails.

This is really annoying if someone is using bnd upload-session . <subject-name>, and e.g. behavior is uploaded nicely, then videos fail, because currently not the whole upload is reverted, so next time running the same command will complain that some files already exist on the server.

A potential solution is that if the uploader function detects that some files we want to upload are already on the server, then it compares the contents of the files, and if they are the same, then it's just skipped. If they are different, an error can be raised.

@AtMostafa
Copy link
Member

sounds good, an easier solution that is acceptable to me at least is just skip the files that are on the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants