Small improvements

BeaconCMS · Dec 18, 2024 · 3fce1b5 · 3fce1b5
1 parent 4295f39
commit 3fce1b5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 15 deletions.
diff --git a/lib/beacon/live_admin/components/visual_editor/name_value_control.ex b/lib/beacon/live_admin/components/visual_editor/name_value_control.ex
@@ -21,11 +21,18 @@ defmodule Beacon.LiveAdmin.VisualEditor.NameValueControl do
         </:header>
 
         <.form :let={f} for={@form} id={@id <> "-form"} phx-target={@myself} phx-submit="save" phx-change="validate">
-          <.input :if={@attribute.editing} field={f[:name]} placeholder="Name" class="w-full py-1 px-2 bg-gray-100 border-gray-100 rounded-md leading-6 text-sm" />
-          <.input :if={@attribute.editing} field={f[:value]} placeholder="Value" class="w-full py-1 px-2 bg-gray-100 border-gray-100 rounded-md leading-6 text-sm" />
-
-          <.input :if={!@attribute.editing} field={f[:name]} placeholder="Name" class="w-full py-1 px-2 bg-gray-100 border-gray-100 rounded-md leading-6 text-sm cursor-not-allowed" disabled />
-          <.input :if={!@attribute.editing} field={f[:value]} placeholder="Value" class="w-full py-1 px-2 bg-gray-100 border-gray-100 rounded-md leading-6 text-sm cursor-not-allowed" disabled />
+          <.input
+            field={f[:name]}
+            placeholder="Name"
+            class={"w-full mb-2 py-1 px-2 bg-gray-100 border-gray-100 rounded-md leading-6 text-sm #{if !@attribute.editing, do: "cursor-not-allowed"}"}
+            disabled={!@attribute.editing}
+          />
+          <.input
+            field={f[:value]}
+            placeholder="Value"
+            class={"w-full py-1 px-2 bg-gray-100 border-gray-100 rounded-md leading-6 text-sm #{if !@attribute.editing, do: "cursor-not-allowed"}"}
+            disabled={!@attribute.editing}
+          />
 
           <.button :if={@attribute.editing} phx-disable-with="Saving..." class="">Save</.button>
           <.button :if={@attribute.editing} type="button" phx-target={@myself} phx-click="discard">Discard</.button>

diff --git a/lib/beacon/live_admin/components/visual_editor/properties_sidebar_component.ex b/lib/beacon/live_admin/components/visual_editor/properties_sidebar_component.ex
@@ -106,16 +106,17 @@ defmodule Beacon.LiveAdmin.VisualEditor.PropertiesSidebarComponent do
           <%= for attribute <- @other_attributes do %>
             <.live_component module={VisualEditor.NameValueControl} id={attribute.id} path={@selected_element["path"]} parent={@myself} attribute={attribute} />
           <% end %>
-
-          <button
-            :if={!@editing}
-            type="button"
-            class="bg-blue-500 hover:bg-blue-700 active:bg-blue-800 text-white font-bold py-2 px-4 rounded outline-2 w-full"
-            phx-click="add_attribute"
-            phx-target={@myself}
-          >
-            + Add attribute
-          </button>
+          <div class="p-4">
+            <button
+              :if={!@editing}
+              type="button"
+              class="bg-blue-500 hover:bg-blue-700 active:bg-blue-800 text-white font-bold py-2 px-4 rounded outline-2 w-full"
+              phx-click="add_attribute"
+              phx-target={@myself}
+            >
+              + Add attribute
+            </button>
+          </div>
         <% end %>
       </div>
     </div>