Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D Positionning Support #2428

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add 3D Positionning Support #2428

wants to merge 1 commit into from

Conversation

CoBC
Copy link
Contributor

@CoBC CoBC commented Aug 13, 2024

This is the last feature we have to retrieve from classic client for interested users with compatible devices.
Unfortunately my devices seams to be incompatible with 3D support, so it's a bit difficult to test it :(

@CoBC CoBC added this to the TeamTalk v5.17 milestone Aug 13, 2024
@CoBC CoBC requested a review from bear101 August 13, 2024 12:01
@CoBC CoBC self-assigned this Aug 13, 2024
@CoBC CoBC removed this from the TeamTalk v5.17 milestone Aug 13, 2024
@bear101
Copy link
Contributor

bear101 commented Aug 13, 2024

hm, it's also not working on my PC. I'm suspecting it's due to a change in PortAudio. I'm suspecting the PAWIN_USE_DIRECTSOUNDFULLDUPLEXCREATE flag which switches to DirectX v8 features. It sounds likely that duplex mode does not support 3D sound.

@CoBC
Copy link
Contributor Author

CoBC commented Aug 13, 2024 via email

@amirmahdifard
Copy link

I also suggest to wait and merge this pr when it has been finished, and then releace 5.17, and announce that 5.17 is completely the death of teamtalk classic, and from that point, teamtalk classic's vertion will no longer be updated, and the installer of teamtalk will no longer update teamtalk classic as it currently does if you already have the older vertion of classic client installed on your system, which is a bug and shouldn't happen!

@beqabeqa473
Copy link
Contributor

I don't think this worked on newer windows versions from windows vista. I think 3d positioning stopped working in versions after windows xp. The problem is that microsoft rewrote whole sound system and to make it work again i think there should be additional tools required.

@CoBC
Copy link
Contributor Author

CoBC commented Aug 14, 2024

@amirmahdifard Really not sure to understand your point, classic client is already officially abandoned for a while now, and Windows installer no longer include it since 5.14 release. If you still have classic client install, only the library will be updated during update, but, anyway, classic executable is no longer updated.
I only mentioned classic client in my PR description to note that this feature was available previously in this client.
Now, we have to determine if it's really difficult to rewrite code to support this feature again or not, however if it never worked after Windows XP, probably there is a bit of refactor to write to get it working again.

@amirmahdifard
Copy link

@CoBC trust me, it stil does. Once I saw someone was in a server with teamtalk classic 5.16, and I asked him, and he said if you first install an older vertion of teamtalk classic such as 5.13 or 5.12,, then if you launch the new installer which doesn't support classic, and you update your qt teamtalk with it, it will also update your classic too. Also, I don't know why bear101 stil updates classic's vertion as wel up on his vertion update commits

@bear101 bear101 marked this pull request as draft September 2, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants